Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace macOS encrypted image on macOS 11+ #3221

Conversation

sweetppro
Copy link
Collaborator

various discussions on this... most recent is here:
closes #3217

various discussions on this... most recent is here:
closes transmission#3217
@sweetppro
Copy link
Collaborator Author

here's a screen from macOS Monterey
Screen Shot 2022-06-06 at 5 03 36 pm

@GaryElshaw
Copy link
Contributor

GaryElshaw commented Jun 6, 2022

Colour; and other code changes in that xib

SCR-20220607-4a7

@ckerr
Copy link
Member

ckerr commented Jun 6, 2022

Just out of curiosity, on what platforms will this be supported and which will it be not supported?

@sweetppro
Copy link
Collaborator Author

sweetppro commented Jun 6, 2022

Just out of curiosity, on what platforms will this be supported and which will it be not supported?

the new system icon will be shown on macOS11+, otherwise the older png file will be shown

@sweetppro sweetppro requested a review from Coeur June 6, 2022 15:19
@GaryElshaw
Copy link
Contributor

Just out of curiosity, on what platforms will this be supported and which will it be not supported?

the new system icon will be shown on macOS11+, otherwise the older png file will be shown

@sweetppro @ckerr Merge mine then this immediately after?

@sweetppro sweetppro changed the title replace macOS encrypted image with system icon if the OS supports it replace macOS encrypted image on macOS 11+ Jun 6, 2022
@ckerr
Copy link
Member

ckerr commented Jun 6, 2022

Approving since this seems to match all the discussion in the other threads.

If anyone doesn't speak up to request changes, I'll merge this tonight

@ckerr ckerr merged commit 5a140d2 into transmission:main Jun 6, 2022
@GaryElshaw
Copy link
Contributor

GaryElshaw commented Jun 7, 2022

If i wanted to change the colour locally, how do i do that @sweetppro?

[NSImage systemSymbol:@"lock.fill" withFallback:@"Lock"] : nil;

@sweetppro ping

@sweetppro sweetppro deleted the macOS-replace-encrpted-icon-with-system-lock-if-OS-supports-it branch June 7, 2022 04:34
@GaryElshaw
Copy link
Contributor

Can these be taken down by a couple of pixels and centred? Note how they don't float in the middle but sit on the line.

SCR-20220608-kye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants