Updated icon for ActionHover on MacOS #3239
Conversation
ckerr
added
enhancement
scope:mac
needs UI review
|
I'm not in favour of this iconographic change. A checkmark is for a "success/done". |
If you look closer, it's a chevron, not a tick. I'm looking at other colours right now, this doesn't have the right appearance.
Same as the MacOS desktop grouping feature.
|
|
Okay, as unsubtle as it is, i'm happy with this.
Previous subtle iteration:
|
|
The black on blue thing is pretty ugly. I'd prefer the "subtle iteration". |
Me too. |
I did try that Oleg, but because the positioning is so janky, at least with the rectangle it looks a little better in its alignment. If @sweetppro can figure out how to recentre the image, i'm happy to remake it. Pretty sure it's coded on L 472 of TorrentCell.mm. |
|
Thanks Oleg, i really like this!
|
|
Crap. None of the light icons work on white-background file-only torrents.
|
I don't think so, unfortunately. It's going to have to be something more drastic :-( ?
It's such a small area to work in. |
|
Thoughts?
|
|
I'm happy.
|
Possibly not, but have a look at the top, i just updated the images. Let me know whether you think it's an improvement or not. |
|
The shadow is clipped in your image. Personally I think it’s unneeded, and goes against Apples HIG |
I'll revert. |
|
Look here for inspiration, semi transparent grey with white icon |
|
That's great, but i can equally see how it could be abused from overuse. Back when i was teaching myself html. The camera image is a rollover, i saw a lot of abuse of that effect during those years. https://web.archive.org/web/20010202065800/http://elshaw.tripod.com/ |
|
here you go: |
|
Thank you, but i feel a bit overwhelmed with all of the grey at the moment. Something sharper feels more appropriate somehow. Probably a personal thing on my part. |
it matches the one it is replacing.... |
|
I know, but i don't think moving away is a necessarily bad thing. |
So don't ask me which one is best. 😸 |
|
Ha! Well at least one of us is easy to please :-) |
|
I like the simple white one, obviously. Especially if it was centred for directories/folders 👎🏼 |
|
Just a theory, but I imagine that Apple adopted a lot of greyish icons to be friendly with colour-blind people? If that's the case, we better stay away from the blue one. |
GaryElshaw
changed the title
|
@ckerr Approved! ^ |
|
Honestly I couldn't figure out action just by looking at this icon. |
I am purposely overlooking that comment. No malice at all, but without a number of other changes within what needs to be coded, there is not a lot of choice on this matter. The icon is literally the basis of the Transmission icon - up and down, for a function that controls the bandwidth for individual torrents - up and down. |
|
I am and have been open to suggestions. As stated at the top, the current icon indicates, generally, preference changes. This PR is trying to indicate that specific per torrent bandwidth changes are available for torrents uploading or downloading. Its aim is a greater level of specificity than the generic 'preferences' icon. What should be there, Oleg? |
|
The inverted chevron is absolutely fine by me, it indicates a menu. |
|
That was the original plan, but the target area is so small...ugh. The lack of centre bothers me, but in the interim it is better. Apologies, what macOS version are you using? |
|
E hoa, I am completely unwilling to put the gear back in, it is entirely inappropriate for this function. It is a menu option, it's not a button, and if it were, it does not change a global preference. PS. There are only two shoes in the world: Doc Marten 8-ups, and John Fluevog Derby Swirls. |
|
Is there consensus on this PR now? It looks like @sweetppro and @Oleg-Chashko are in favor, and @nevack was opposed but to a previous design. |
As per this discussion I don't really have opinions on the macOS UI on its own & would rather get consensus from actual macOS app contributors / users and then merge or decline PRs based on that consensus. 🙂 I'd mostly only vote on UI changes if they have other factors, e.g. if they fix a bug / improve a feature / increase maintainability. From @Oleg-Chashko's summary it sounds like people mostly approve of this iteration or have disapproved of a previous iteration and/or are silent. Since we're a group of people online in different timezones, let's emoji-vote. It's easy and I've found it to work very well on other projects, and I think it could work well for our group here. How it works: add a reaction to this comment: 👍 PR should be merged as-is In 24 hours I'll merge if there are "enough" 👍 and iff there are no 😕 👀 👎 CC @transmission/contributors |
It's a tidy-up of macOS iconography for the macOS 11 - 12 age. The recent addition of the ellipsis icon in the bar at the bottom was about introducing an actual default macOS icon that Apple uses for that function; this is a similar change. The current icon does or doesn't do the following:
|
|
So we all agree on the gray ellipsis? |
|
Wait, what? I thought we agreed on doc.append.fill because the googly eyes were amusing?
|
|
I'm not sure how to handle PRs like this -- I try to not make macOS UI calls myself and try to get consensus from macOS contributors / users, but it doesn't look like anyone else has strong opinions on this PR. I think I'll merge this one and see if anyone complains. |
White with dark transparent background
Subtle is always better.
Okay, i think i'm finally happy with this.
I think this *might* make everyone happy.
With my thanks to @sweetppro
A secondary change to, arguably, make the MacOS iconography more in keeping with the modern MacOS environment, and to make it clear that we're differentiating a menu item from a button.
Complementary to #3178, they both signify to the user that additional options are available to the user from a menu. Unlike the global speed changes in #3178, this is for adjusting individual torrent speeds using an Apple SF Symbols icon (chevron.down.circle.fill).