Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NSAttributedString deprecation #3330

Merged
merged 1 commit into from Jun 20, 2022

Conversation

fxcoudert
Copy link
Collaborator

Do not use the deprecated [NSAttributedString initWithPath:documentAttributes:] method.

@ckerr
Copy link
Member

ckerr commented Jun 20, 2022

The CI failure is unrelated to the PR

@ckerr ckerr merged commit 2ac049c into transmission:main Jun 20, 2022
@fxcoudert fxcoudert deleted the NSAttributedString branch June 21, 2022 07:06
@ckerr
Copy link
Member

ckerr commented Jun 21, 2022

Hmmm why didn't this kick off code-style CI

edit: aha, found the culprit and appended a fix to the code style PR at #3334

commit 01fcb34a6433c5309f4adfcc8e7d601557150bd5 (HEAD -> build/try-giving-a-style-breadcrumb, origin/build/try-giving-a-style-breadcrumb)
Author: Charles Kerr <charles@charleskerr.com>
Date:   Tue Jun 21 11:37:40 2022 -0500

    fix: typo in what-to-make

diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml
index b401094ea..646ba1d63 100644
--- a/.github/workflows/actions.yml
+++ b/.github/workflows/actions.yml
@@ -45,9 +45,9 @@ jobs:
           set +e
           git -C "${GITHUB_WORKSPACE}/src" diff --exit-code origin/main -- CMakeLists.txt Transmission.xcodeproj third-party libtransmission cli
           echo "::set-output name=cli-changed::$?"
-          git -C "${GITHUB_WORKSPACE}/src" diff --exit-code origin/main -- CMakeLists.txt Transmission.xcodeproj libtransmission cli daemon gtk macos qt utils tests web third-party
+          git -C "${GITHUB_WORKSPACE}/src" diff --exit-code origin/main -- CMakeLists.txt Transmission.xcodeproj libtransmission cli daemon gtk macosx qt utils tests web third-party
           echo "::set-output name=any-code-changed::$?"
-          git -C "${GITHUB_WORKSPACE}/src" diff --exit-code origin/main -- CMakeLists.txt Transmission.xcodeproj libtransmission cli daemon gtk macos qt utils tests web
+          git -C "${GITHUB_WORKSPACE}/src" diff --exit-code origin/main -- CMakeLists.txt Transmission.xcodeproj libtransmission cli daemon gtk macosx qt utils tests web
           echo "::set-output name=our-code-changed::$?"
           git -C "${GITHUB_WORKSPACE}/src" diff --exit-code origin/main -- CMakeLists.txt Transmission.xcodeproj third-party libtransmission daemon
           echo "::set-output name=daemon-changed::$?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants