Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new svg icons for Qt client #3377

Merged
merged 33 commits into from Jul 3, 2022
Merged

Conversation

GaryElshaw
Copy link
Contributor

@GaryElshaw GaryElshaw commented Jun 29, 2022

Fixes #3349.

There are a number of changes here with new svg icons replacing the old png versions, and changes to the .qrc file for the svg files, but also an addition to include a turtle png icon for the Qt preferences window.

The icons and their source/licensing information:

  1. Turtle icon: https://commons.wikimedia.org/wiki/File:491-turtle.svg
  2. Ratio/Yin Yang icon: https://commons.wikimedia.org/wiki/File:Yin_and_Yang_symbol.svg
  3. Lock icon: https://twemoji.maxcdn.com/
    License: Code licensed under MIT. Graphics licensed under CC-BY
  4. Utilities icon: Mike’s PR: Switch from Faenza to Win11 icon theme for Windows/Mac #2283

The qrc file has been adapted to include the new turtle icon as a png because the svg version wasn't scaling correctly in the preferences window. In fact, the preferences window almost became just the turtle icon. This meant a small code change to PrefsDialog.ui.

@ckerr ckerr changed the title New QT svg icons Add new svg icons for Qt client Jun 29, 2022
@ckerr ckerr self-requested a review June 29, 2022 14:56
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I'm not a big fan of that new turtle icon. This may be crazy but maybe something like https://commons.wikimedia.org/wiki/File:491-turtle.svg? I am a customer here who doesn't know what they want, but knows what they don't want 🙂

  • If we're replacing icons, is there any reason to keep them around in a separate folder, or should we just remove the old ones altogether?

  • I appreciate the citation / licensing info for the new icons 👍

@ckerr
Copy link
Member

ckerr commented Jun 29, 2022

transmission

I found an svg of it online 🎉 This certainly looks better than the old png

@Pentaphon
Copy link

Pentaphon commented Jun 29, 2022

I was about to comment the very same thing. We need a nicer turtle for 4.0 and something emoji-ish like that would be perfect and way easier to discern on screens.

Here's some more if we want to get a simpler turtle.

https://emojipedia.org/turtle/

I like Mozilla's if we need something simple and open source.

If we're replacing icons, is there any reason to keep them around in a separate folder, or should we just remove the old ones altogether?

I don't think anybody will miss the old icons...they can be found online elsewhere if anybody is feeling that nostalgic.

@ckerr
Copy link
Member

ckerr commented Jun 30, 2022

Here's some more if we want to get a simpler turtle.

https://emojipedia.org/turtle/

If we use any of these we need to check the licensing. We don't want to run into an SF Icon style problem.

The Mozilla one is nice and should be some sort of CC license

@ckerr
Copy link
Member

ckerr commented Jun 30, 2022

🤔 would a hamburger menu icon make sense here?

@GaryElshaw

This comment was marked as off-topic.

@ckerr

This comment was marked as off-topic.

@GaryElshaw

This comment was marked as off-topic.

@ckerr
Copy link
Member

ckerr commented Jul 1, 2022

Yeah this idea has come up before. The conclusion we came to was that the speed button would be too confusing; that people would either (a) think it was a "go fast" button or (b) think it was to show the current speed

I'm kind of fond of the turtle and it's a good metaphor for "go slow". If there was another universal "slow" icon that might be better than the speedometer.

@GaryElshaw
Copy link
Contributor Author

GaryElshaw commented Jul 1, 2022

:-)

hare

to

tortoise

@Pentaphon
Copy link

Pentaphon commented Jul 1, 2022

I'm kind of fond of the turtle and it's a good metaphor for "go slow". If there was another universal "slow" icon that might be better than the speedometer.

Ok if we want to stay with the animal motif...We can keep the turtle...like this one....

https://www.svgrepo.com/svg/309992/slow-mode

Or....

How about something even slower, and simpler to convey than a turtle like this simple snail?

https://www.svgrepo.com/svg/261807/snail

More snails here if you'd like to look around: https://www.svgrepo.com/vectors/snail/

Then you can switch to a fast and universally recognized animal like this simple hare?

https://www.svgrepo.com/svg/309614/fast-mode

We'd have 2 distinct yet simple icons and no need to change colors for dark and light modes.

Turtle and hare OR snail and hare would totally work and be easy to use without coloring them.

@ckerr
Copy link
Member

ckerr commented Jul 2, 2022

Noooo we're not putting a snail on the app 😆

@Pentaphon
Copy link

Noooo we're not putting a snail on the app

Alright, but what about the turtle and hare icon combo?

They are Microsoft's MIT-licensed "slow and fast mode" icons.

Turtle: https://www.svgrepo.com/svg/309992/slow-mode
Hare: https://www.svgrepo.com/svg/309614/fast-mode

sort the qresource entries in application.qrc
@ckerr
Copy link
Member

ckerr commented Jul 2, 2022

I hear what you're saying about using using the Fluent icons for slow mode, particularly since transmission-qt's main platform is Windows. We should also consider this for transmission-gtk, since GNOME UI icons use a 'symbolic' monochrome style.

TBH I think I'd like to consider the fluent turtle in a separate issue than this since it probably will cross between transmission-qt, transmission-gtk (and maybe the web client too?)

@Pentaphon could you open a new issue for the slow mode icon?

@ckerr

This comment was marked as off-topic.

@mangosplat
Copy link

I understand the hesitancy to switch from the turtle, it's an iconic part of the transmission gui at this point!

I see the same problem with the spedometers existing with using both a turtle and hare (users beleiving hare is a fast mode). Agree it should be discussed in a separate issue.

@Pentaphon
Copy link

I understand the hesitancy to switch from the turtle, it's an iconic part of the transmission gui at this point!

I understand it, too. I was just throwing ideas out there and since we are going in new directions for 4.0 and I figured that new suggestions wouldn't hurt.

TBH I think I'd like to consider the fluent turtle in a separate issue than this since it probably will cross between transmission-qt, transmission-gtk (and maybe the web client too?)

@Pentaphon could you open a new issue for the slow mode icon?

Done! #3392

@GaryElshaw

This comment was marked as off-topic.

@ckerr ckerr closed this Jul 3, 2022
@ckerr ckerr reopened this Jul 3, 2022
@ckerr

This comment was marked as off-topic.

@GaryElshaw

This comment was marked as off-topic.

@ckerr ckerr merged commit 083529c into transmission:main Jul 3, 2022
@GaryElshaw GaryElshaw deleted the qt-icons branch July 3, 2022 01:42
@mikedld
Copy link
Member

mikedld commented Jul 3, 2022

This broke MSI packaging on Windows :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] Icons blurry when display scaled.
5 participants