Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS preference window localization autolayout fixes #3472

Merged
merged 5 commits into from Jul 21, 2022
Merged

macOS preference window localization autolayout fixes #3472

merged 5 commits into from Jul 21, 2022

Conversation

sweetppro
Copy link
Collaborator

Fixes: #3467

@ckerr ckerr added the needs UI review This PRs has UI changes that need review label Jul 18, 2022
@sweetppro sweetppro changed the title macOS preference window Turkish localization autolayout fix macOS preference window localization autolayout fixes Jul 19, 2022
@ckerr
Copy link
Member

ckerr commented Jul 20, 2022

Can someone give this a spin and review it? :)

@GaryElshaw
Copy link
Contributor

Unfortunately this version is also giving me a one-bounce-in-the-dock result :-( The nightlies from Jenkins are working fine.

nevack
nevack approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@nevack nevack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oleg-Chashko
Copy link
Contributor

Can someone give this a spin and review it? :)

Bandwidth, Turkish

Remote, Spanish

Remote, Italian

@sweetppro sweetppro removed the needs UI review This PRs has UI changes that need review label Jul 20, 2022
@ckerr ckerr force-pushed the prefs-window-fix branch 3 times, most recently from 9ff8d43 to dd7f996 Compare July 21, 2022 05:02
@sweetppro
Copy link
Collaborator Author

@ckerr this PR is ready :)

@ckerr ckerr merged commit f9398e5 into transmission:main Jul 21, 2022
@ckerr ckerr mentioned this pull request Jul 21, 2022
Closed
@sweetppro sweetppro deleted the prefs-window-fix branch July 21, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevack nevack nevack approved these changes

Assignees
No one assigned
Labels
scope:mac type:fix A bug fix type:ui
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[macOS] UI-Preferences -> Bandwidth, Turkish localization, v.3.00+ffe307ac1b
5 participants
@sweetppro @ckerr @GaryElshaw @Oleg-Chashko @nevack