New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new flag in remote for connecting through a Unix domain socket. #3552
Add a new flag in remote for connecting through a Unix domain socket. #3552
Conversation
Codewise this LGTM and how I would have done it. It appears curl is doing the right thing behind the scenes in checking for the socket path length. However, it isn't passing this feedback to the user. Consider this:
vs.
This is not good UI imo, especially given the fact that curl is in fact providing this as feedback:
The second thing to notice from this is that I can use whatever host/port I want and it works, I think that's confusing but truth be told it doesn't really affect anything, Besides that UI nit, I'm wondering long term if @mikedld's was right in #3544. One of my goals if I stop being lazy is to make unix sockets also accept raw JSON instead of using HTTP for rpc. In this case it would make sense to parse |
@LaserEyess I don't understand what I should change about the output. Also are the check fails my fault? |
The check doesn't fail, it succeeds, but the feedback isn't being given to the user. That's my point. I don't really think it's a dealbreaker, I haven't even looked at how |
Sorry for the delay. Other errors are handled the same way. This seems to be a problem only on the master branch, the last release works fine. |
I added a new argument and passed it over to libcurl like how curl's --unix-socket argument works.
Closes #3544.