Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Fix SubprocessTest on macOS Monterey and later. #3812

Merged
merged 2 commits into from Oct 8, 2022
Merged

tests: Fix SubprocessTest on macOS Monterey and later. #3812

merged 2 commits into from Oct 8, 2022

Conversation

nevack
Copy link
Member

@nevack nevack commented Sep 11, 2022

On macOS Monterey and later /var is symlinked to /private/var

Add missing tr_sys_path_resolve(...) for parent dir in sandbox fixture.

Fixes #2102

@nevack
tests: Fix SubprocessTest on macOS Monterey and later.
d57fa1d 
On macOS Monterey and later `/var` is symlinked to `/private/var`

Add missing `tr_sys_path_resolve(...)` for parent dir in sandbox
fixture.

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
@nevack
Copy link
Member Author

nevack commented Sep 15, 2022

@ckerr Can you help me here? Looks like this breaks 1 test on Windows, but I cannot debug it as I have no Windows machine right now.
I think I can install trial, version ARM64 version in UTM on my M1 Mac, but maybe it's something very trivial and you will figure it out just by looking at it :)

@ckerr
Copy link
Member

ckerr commented Sep 15, 2022

@nevack I'm mostly afk this week & will be able to help you sometime early next week

@nevack
Copy link
Member Author

nevack commented Sep 15, 2022

@nevack I'm mostly afk this week & will be able to help you sometime early next week

Okay, no hurry here, just do not want this to be lost :)

@ckerr ckerr self-requested a review September 20, 2022 15:44
@Coeur
Copy link
Collaborator

Coeur commented Oct 8, 2022

@nevack can you rebase? The build failure was lost, as it got too old.

@nevack
Copy link
Member Author

nevack commented Oct 8, 2022 •
edited

@nevack can you rebase? The build failure was lost, as it got too old.

Merged main into this branch via GitHub UI, let's check it now.

@mikedld mikedld merged commit ecc7c18 into transmission:main Oct 8, 2022
@ckerr
Copy link
Member

ckerr commented Nov 26, 2022

Notes: Improve libtransmission unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedld mikedld mikedld approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
scope:test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing tests in tests/libtransmission on macOS Monterey
4 participants
@nevack @ckerr @Coeur @mikedld