fix: thread-sanitizer warnings in SandboxedTests

[ckerr]

fix: thread-sanitizer warnings in SandboxedTest::blockingTorrentVerify

fix: thread-sanitizer warnings in SandboxedTest::createTorrentAndWaitForVerifyDone()

[GaryElshaw]

Charles, just about every file in libtransmission now has this warning during make, is that a foreseen change? @ckerr

/libtransmission/session.h:1006:40: warning: declaration requires an exit-time destructor [-Wexit-time-destructors] static inline std::recursive_mutex session_mutex;

[ckerr]

@GaryElshaw I've got another small thread PR in the works; I'll fix it there. Thanks for the heads-up; I'm not seeing that warning here on my build 🤷‍♂️

[GaryElshaw]

No worries!

[nevack]

@GaryElshaw I've got another small thread PR in the works; I'll fix it there. Thanks for the heads-up; I'm not seeing that warning here on my build man_shrugging

I also see it, maybe Xcode's AppleClang specific

[ckerr]

Notes: Turned on more clang-tidy checks and fixed warnings.