Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize CMake code (ongoing refactoring) #4507

Merged
merged 25 commits into from
Jan 1, 2023
Merged

Modernize CMake code (ongoing refactoring) #4507

merged 25 commits into from
Jan 1, 2023

Conversation

mikedld
Copy link
Member

@mikedld mikedld commented Jan 1, 2023

No description provided.

@mikedld mikedld added type:refactor A code change that neither fixes a bug nor adds a feature type:build Changes that affect the build system labels Jan 1, 2023
@mikedld
Reformat CMake code
33ef4b3
@mikedld
Bump minimum CMake version to 3.12
798d02b
@mikedld
Add target sources separately via target_source()
8a0b32c
@mikedld
Make tr_win32_app_info() add target sources on its own
fb363f3
@mikedld
Don't use include_directories()
c4cb0f7
@mikedld
Don't use add_definitions()
19f5b02
@mikedld
Limit use of add_compile_options()
98973c8
@mikedld
Move VDKQueue target declaration to a subdirectory
59eee32
@mikedld
Add tr_disable_source_files_compile() helper
4e9d634
@mikedld
Add tr_target_glib_resources() helper
3e72cdd
@mikedld
Add tr_gettext_msgfmt() helper
05282a4
@mikedld
Enable AUTOUIC for Qt client
8030cfd
@mikedld
Enable AUTORCC for Qt client
7c32fb6
@mikedld
Remove AUTO{MOC,RCC,UIC} source group overrides
045e8c6
@mikedld
Add tr_target_idl_files() helper
edf3795
@mikedld
Move source group setup to tr_qt_add_translation()
5688cad
@mikedld
Add tr_target_xib_files() helper
bc6c295
@mikedld
Prefer target_sources() to intermediate variables
44838d3
@mikedld
Use explicit visibility versions of target_*() commands
3efbdf2
@mikedld
Prefer genexes to conditions in target_*() commands
440df88
@mikedld
Add tr_allow_compile_if() helper
0d76c7e
@mikedld
Leave only top-level project(), remove the rest
a4160d1
@mikedld
Minor fixups
d9f3ecc
@mikedld
Fixup Mac QL plugin install
09a9945
@mikedld
Fixup IDE target folders and source groups
eb494ab
@ckerr ckerr mentioned this pull request Jan 1, 2023
Merged
@mikedld mikedld merged commit bc38051 into main Jan 1, 2023
@mikedld mikedld deleted the refactor/cmake branch January 1, 2023 19:49
@ckerr ckerr added the notes:none Should not be listed in release notes label Jan 1, 2023
GaryElshaw added a commit to GaryElshaw/transmission that referenced this pull request Jan 2, 2023
@GaryElshaw
Update cmakelists to match transmission#4507
5eea1bd
@ckerr ckerr mentioned this pull request Jan 21, 2023
Merged
ckerr added a commit that referenced this pull request Feb 11, 2023
@ckerr
Revert "Modernize CMake code (ongoing refactoring) (#4507)"
6c7c0eb 
This reverts commit bc38051.
@Coeur Coeur mentioned this pull request Dec 14, 2023
Open
@Coeur Coeur mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
notes:none Should not be listed in release notes type:build Changes that affect the build system type:refactor A code change that neither fixes a bug nor adds a feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikedld @ckerr