add remote HTTPS support to Qt GUI #4622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ckerr
requested changes
Jan 20, 2023
anarcat
force-pushed
the
https-support
branch
from
26afe4a
to
039e4b6
Compare
ckerr
requested changes
Jan 21, 2023
anarcat
force-pushed
the
https-support
branch
from
701becf
to
178dea4
Compare
ckerr
approved these changes
Jan 22, 2023
ckerr
force-pushed
the
https-support
branch
2 times, most recently
from
0548c46
to
9b23a76
Compare
mikedld
requested changes
Jan 26, 2023
anarcat
force-pushed
the
https-support
branch
from
bef185f
to
3762cf4
Compare
mikedld
approved these changes
Jan 26, 2023
This is a rather naive implementation that copies parts of the SESSION_REMOTE_HOST settings and replaces HOST with HTTPS, basically. We pull some ideas from the SESSION_REMOTE_AUTH parameter as well (because it's a boolean) and we otherwise do not really know what we are doing here. In particular, we didn't add a new commandline flag for this, as I am not sure what it would be called. This explicitely does *not* add GUI elements as those were found to be too confusing, as the backend does not support HTTPS. See transmission#4593 for the details of that discussion. I actually would have much rather this be turned in a single URL instead of having flags, UI elements and settings for what is ultimately just a string, but that is yet another yak to shave... Closes: transmission#1294
This is a rather naive implementation that copies parts of the SESSION_REMOTE_HOST settings and replaces HOST with HTTPS, basically. We pull some ideas from the SESSION_REMOTE_AUTH parameter as well (because it's a boolean) and we otherwise do not really know what we are doing here. In particular, we didn't add a new commandline flag for this, as I am not sure what it would be called. This explicitely does *not* add GUI elements as those were found to be too confusing, as the backend does not support HTTPS. See transmission#4593 for the details of that discussion. I actually would have much rather this be turned in a single URL instead of having flags, UI elements and settings for what is ultimately just a string, but that is yet another yak to shave... Closes: transmission#1294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather naive implementation that copies parts of the SESSION_REMOTE_HOST settings and replaces HOST with HTTPS, basically. We pull some ideas from the SESSION_REMOTE_AUTH parameter as well (because it's a boolean) and we otherwise do not really know what we are doing here.
In particular, we didn't add a new commandline flag for this, as I am not sure what it would be called.
This explicitely does not add GUI elements as those were found to be too confusing, as the backend does not support HTTPS. See #4593 for the details of that previous discussion.
I actually would have much rather this be turned in a single URL instead of having flags, UI elements and settings for what is ultimately just a string, but that is yet another yak to shave...
Closes: #1294