Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for torrent-get calls with the key percentComplete #470

Closed
wants to merge 1 commit into from

Conversation

mhadam
Copy link
Contributor

@mhadam mhadam commented Jan 15, 2018

percentDone is already available as a key when calling torrent-get over RPC - it describes the amount of data downloaded as a percent of the files that are wanted in the torrent. I'm interested in getting percentComplete - the data downloaded as a percent of the complete torrent size. percentComplete is already included in tr_stat so it's an easy add.

@ckerr
Copy link
Member

ckerr commented Oct 18, 2021

I know how long this PR has been in limbo and am going through older PRs to try and clear the backlog by getting some of them merged or closed.

@mhadam is this PR something you'd like to see merged; and if so, could you update it to resolve merge conflicts with the current codebase? Also, could you add documentation for this field in extras/rpc-spec.txt?

@ckerr ckerr added needs update The PR has needs to be updated by the submitter type:feat A new feature scope:core labels Oct 18, 2021
@ckerr
Copy link
Member

ckerr commented Feb 13, 2022

#2615 supersedes this PR, which cannot be merged due to merge conflicts. @mhadam still has authorship credits in #2615; I only made a separate PR to resolve the merge conflicts.

@ckerr ckerr closed this Feb 13, 2022
@ckerr ckerr removed scope:core needs update The PR has needs to be updated by the submitter type:feat A new feature labels Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants