fix: regression (leech percentage) from earlier progress-indicator work #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a regression that I missed from last year. The web client now uses the same progress indicators from the client, and also slightly changes the color based on light/dark mode. transmission#4303
I found a few more statuses that I missed that didn’t match native client ui: - queued - paused queued - paused leech - paused magnet - dark mode variants - verify percentage and color Plus, reduce brightness of some colors in light mode. This got _a lot_ of testing. This obviously brings up the fact that it's hard to cover all torrent states, so I'm working on some mock data we can use with a visual regression too. [issue](transmission#5107)
|
This is great work, @dareiff. |
ckerr
added
type:ui
type:fix
|
Notes: Improved colors in both light & dark mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not only a regression fix for leeching percentage display, but actually goes quite a bit deeper into ALL of the various states. All of my sincere apologies for not noticing leech state earlier and jumping the PR gun. (See last paragraph for fixes to this problem.)
I found a few more statuses that I missed that didn’t match native client ui:
This got a lot of testing, dark and light modes. There are some future improvements I’d like to make on this, but those are in the hopper on another branch that will be in a minor (semver) PR.
This obviously brings up the fact that it's hard to cover all torrent states, so I'm working on some mock data we can use with a visual regression too. issue