fixup: refactor handshake objects to use socket address as key as well #5644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed in favour of #5645, which contains a superset of the changes here. |
|
TBH I'd prefer single-topic PRs just on principle, and also in this specific case because I'm considering backporting the |
ckerr
force-pushed
the
multiple-conn-fixup
branch
from
135a74b
to
8be96c4
Compare
ckerr
approved these changes
Jun 20, 2023
ckerr
added
scope:core
type:refactor
I am absolutely in favor of this since 4.1.0 is definitely going to take a good long while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #5619.
TODO: Too many
std::make_pair()calls now for my liking. Further refactoring coming up in a future PR.