Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: share CompareCacheBlockByKey by constexpr static member #5678

Merged
merged 1 commit into from Jun 28, 2023

Conversation

tearfur
Copy link
Member

@tearfur tearfur commented Jun 28, 2023

Avoid constructing a new compare callable object each time the member functions in cache.cc are called.

@tearfur tearfur changed the title perf: share CompareCacheBlockByKey by constexpr static member refactor: share CompareCacheBlockByKey by constexpr static member Jun 28, 2023
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ckerr ckerr added scope:core type:perf A code change that improves performance semver:patch make backwards compatible bug fixes labels Jun 28, 2023
@ckerr ckerr added this to the 4.0.x milestone Jun 28, 2023
@ckerr ckerr added the notes:none Should not be listed in release notes label Jun 28, 2023
@ckerr ckerr merged commit 7fa1498 into transmission:main Jun 28, 2023
21 checks passed
@tearfur tearfur deleted the cache-tidy branch June 28, 2023 15:27
ckerr pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:none Should not be listed in release notes scope:core semver:patch make backwards compatible bug fixes type:perf A code change that improves performance
Development

Successfully merging this pull request may close these issues.

None yet

2 participants