Clean code for qt5 #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt4 is too old, kill it. Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
C++11 range based for will detach qt containers, creating a temporary copy of all the elements. Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Also, added a Q_OBJECT on some inheritances. Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Because of the code style chosen for Transmission, each single method takes at least six lines of boilerplate transforming one-liners slots to lambdas will remove tons of uneeded lines, making the code easier to read and write. Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Easier to read, no static_cast necessary Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@gmail.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@gmail.com>
They are faster in runtime, and they break the compilation if you choosed a wrong one. Signed-off-by: Tomaz Canabrava <tomaz.canabrava@gmail.com>
Virtual should be used to create a virtual method override should be used when you are using a virtual method this way compiler will know when you made a mistake (actually catched two misusages because of this. :) Signed-off-by: Tomaz Canabrava <tomaz.canabrava@gmail.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@gmail.com>
only made sense on ancient qt versions. Signed-off-by: Tomaz Canabrava <tomaz.canabrava@gmail.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@gmail.com>
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@gmail.com>
|
closing because of a updated version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove qt4 support and start to clean the code to get what qt5 + c++11 has to offer.