fix: json string serializer improperly escaping characters (#6005) #6133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion#6005) * feat: escape json string according to RFC8259 * fix: do not append newline when json serde is in compact mode * fix: json tests 1. Use the same locale settings as the apps 2. Added additional test case for a string that are known to be prone to locale issues 3. Removed test for escaping non-BMP characters to UTF-16 escape sequences * chore: add more test cases to `JSONTest.testUtf8` * chore: order cases in the same order as RFC8259 (cherry picked from commit 0259edb)
ckerr
approved these changes
Oct 20, 2023
|
Notes: Fixed a bug where Transmission is incorrectly escaping JSON strings in some locales. (Copied from #6005) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherrypick to
4.0.x.