fix: build when compiling with GTKMM-4

[Coeur]

Fix #6392

[mikedld]

This makes no sense, at least not in main — as noted by @GaryElshaw, minimum is 4.11.1 so checking for 4.10 is pointless. If applicable to 4.0.x (where minimum is lower), feel free to retarget.

[Coeur]

@mikedld retarget done

[GaryElshaw]

@Coeur Yep, this needs to be done on the 4.0 branch. This is from the 4.1 branch, i'm wondering if those 3 and 4 designations need to be included in the 4.0 branch cmakelists file.

set(GTKMM3_MINIMUM 3.24.0) set(GTKMM4_MINIMUM 4.11.1)

[mikedld]

get_files() in 4.0-4.10 returns a model, not a vector, so IIUC this won't compile. I thought we had get_files2() reverted in 4.0.x, looking at #6144, why would it still be there?..

[mikedld]

I think @ckerr may have unnecessarily cherry-picked bd31d80 (seeing how there was no PR and the one referred to in commit subject line is against main), reverting it should do the trick.

EDIT: To be fair, #6131 does state that it targets 4.0.x milestone, just that the fix in two branches was meant to be different...

[ckerr]

@mikedld yes, agreed. I think I goofed that one.

[ckerr]

Notes: Fixed build when compiling with GTKMM 4.