build with -latomic on platforms that need it #6774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to test that this fixes the issue, but setting up |
Coeur
reviewed
Apr 23, 2024
|
You marked the PR as draft. Is it ready for review and tested? |
|
Still working on it, does not compile. |
|
All good now. |
|
CC @mikedld for CMake review |
mikedld
reviewed
Jun 1, 2024
mikedld
reviewed
Jun 3, 2024
mikedld
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067625 and failure to build transmission on specific platforms that require
-latomic, here is the way to a proper fix.