Web: Improves responsive design #775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The device-width CSS media feature is deprecated, and using it can cause unexpected behaviour if the viewport width is 480px or less but the device's total screen width is greater than 480px.
bennap
previously approved these changes
Feb 4, 2019
|
I know how long this PR has been in limbo and am trying to go through the project's backlog of older PRs. @Sesquipedalian is this PR still germane after the web client refresh that landed in #1476? I believe many of the items in the description got addressed, e.g. the footer and mobile use, but I don't know if there are items that are still not addressed in |
ckerr
added
scope:web
needs clarification
|
No, this PR is far too stale to be relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Loads mobile.css based on max-width instead of max-device-width.
The device-width CSS media feature is deprecated, and using it can cause unexpected behaviour if the viewport width is 480px or less but the device's total screen width is greater than 480px.
Prevents the torrent inspector from overflowing the viewport.
Positions the footer at the bottom of the viewport on narrow devices, just like on larger ones.
Prevents the toolbar from overflowing the viewport on narrow devices.