-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web client improvement #815
Conversation
@livings124 @mikedld would you like to take a look? Thanks. |
2790b25
to
a4e3e3c
Compare
@ckerr can you help review this one? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 on most of the ideas here. Some suggestions:
-
Even though the end result would be the same, I'd prefer to see these separate topics broken into their own PRs since they're unrelated. For example, the jQuery / jQuery UI bumps are not related to the indentation styling, and neither are related to the
index.html
exec flag bugfix. So those all belong in separate PRs. -
The jQuery UI refresh grew the png sizes. I think previously what we did was run them through pngcrush or pngquant to shrink them down ... could you do that on these new icons as well to remove that new overhead?
-
I'm not in love with the idea of removing the source versions of the minified files. IIRC we don't bundle them into our release -- and if we do, I'd 👍 a patch that stopped that from happening -- but it's still useful to have them in the repo for reference.
Only the minified jquery.ui-contextmenu.min.js is referenced, it already has license & version info in the header, so src file is not needed.
@ckerr thanks for the comment, I've updated the PR, please take a look ;) |
@ckerr do you have a minute to take a look at the revised result? Thanks a lot. |
I realize how long this PR has been in limbo and am trying to clear through some of the backlog. This PR is no longer applicable because jQuery is no longer used in the web client as of #1476. |
This PR contains changes as below:
Please let me know if there is anything needs to be changed here, thanks!