Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TR_TORRENT_LABELS to env variables available to scripts #868

Merged
merged 3 commits into from May 13, 2020
Merged

Add TR_TORRENT_LABELS to env variables available to scripts #868

merged 3 commits into from May 13, 2020

Conversation

qu1ck
Copy link
Contributor

@qu1ck qu1ck commented Mar 31, 2019

Requested by @Belphemur

With this scripts can determine actions based on labels without need to query torrent info.

@Belphemur
Copy link

@mikedld @ckerr this is directly linked to #822 that has been merged lately in master.

This way I can close #137 and do a PR for adding label directly in the web interface.

@qu1ck
Copy link
Contributor Author

qu1ck commented Apr 8, 2019

Friendly ping :)

mikedld
mikedld requested changes Apr 19, 2019
View reviewed changes
libtransmission/utils.c Outdated Show resolved Hide resolved
libtransmission/utils.c Outdated Show resolved Hide resolved
libtransmission/utils.c Outdated Show resolved Hide resolved
libtransmission/utils.c Outdated Show resolved Hide resolved
libtransmission/utils.c Outdated Show resolved Hide resolved
@qu1ck qu1ck force-pushed the script-env branch 2 times, most recently from 2721c1e to 67f063a Compare April 20, 2019 05:08
@qu1ck
Copy link
Contributor Author

qu1ck commented Apr 20, 2019

Done, PTAL.

@mikedld
Copy link
Member

mikedld commented Apr 21, 2019

Please add a unit test for newly added tr_strjoin function, otherwise LGTM.

@qu1ck qu1ck force-pushed the script-env branch 3 times, most recently from 22886fb to 89ccea6 Compare April 23, 2019 05:53
@qu1ck
Copy link
Contributor Author

qu1ck commented Apr 23, 2019

New unit test, fresh from the bakery.

@qu1ck
Copy link
Contributor Author

qu1ck commented Apr 28, 2019

Anything else needed to get this merged?

@qu1ck
Copy link
Contributor Author

qu1ck commented Jun 4, 2019

ping

@Belphemur
Copy link

Ping @mikedld

1 similar comment
@Belphemur
Copy link

Ping @mikedld

@qu1ck
Copy link
Contributor Author

qu1ck commented Oct 25, 2019

Maybe pinging @ckerr will work better :)

@qu1ck
Copy link
Contributor Author

qu1ck commented Apr 28, 2020

This PR is 1 year old now

@ckerr ckerr merged commit 2fab317 into transmission:master May 13, 2020
@qu1ck qu1ck deleted the script-env branch May 14, 2020 07:17
@ckerr ckerr added type:feat A new feature scope:core labels Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@mikedld mikedld mikedld approved these changes

Assignees
No one assigned
Labels
scope:core type:feat A new feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qu1ck @Belphemur @mikedld @ckerr