Refactor tr_torrentFindFile2 #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: RobCrowston <crowston@protonmail.com>
ckerr
approved these changes
Oct 21, 2019
|
Is there anything else I need to do to get these PRs in? |
|
Rebase to remove all the merge commits? |
I didn't do anything special -- GitHub has a button to get the PR in sync with master so that it can be merged, and I pushed that button. 😐 When committing to master, I'll use squash-and-merge to remove some of that noise in the commit log. |
ckerr
added
type:refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.