Ed25519 operation fixtures #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjgd
requested review from
acarnagey,
BenjaminMoe,
ipbyrne and
OR13
as code owners
OR13
reviewed
Feb 7, 2022
| @@ -30,7 +30,7 @@ | |||
| "tsdx": "^0.14.1" | |||
| }, | |||
| "dependencies": { | |||
| "@decentralized-identity/ion-sdk": "^0.5.0", | |||
| "@gjgd/ion-sdk": "0.5.2", | |||
There was a problem hiding this comment.
@gjgd I suggest we just move your fork here... I don't like to be dependent on things we can't update easily here... which I guess includes ion sdk given your comments on the PR.
OR13
approved these changes
Feb 7, 2022
|
PR looks good, I opened #362 to track handling updates to that SDK moving forward. The TLDR is that we probably want to prove that changes to the SDK don't break the integration tests, so we probably want the sdk next to the integration tests that we have in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276
Had to fork ion-sdk because the changes are currently blocked: decentralized-identity/ion-sdk#23 ping @OR13 You may want to fork it under transmute-industries org