Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for eth private key #375

Merged
merged 3 commits into from
Feb 22, 2022
Merged

Add support for eth private key #375

merged 3 commits into from
Feb 22, 2022

Conversation

gjgd
Copy link
Contributor

@gjgd gjgd commented Feb 22, 2022

fixes #374

Add support for ETHEREUM_PRIVATE_KEY in element config.

Change is backwards compatible: ETHEREUM_PRIVATE_KEY is ignored if ETHEREUM_MNEMONIC is passed

Copy link
Member

@BenjaminMoe BenjaminMoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this change. For allowing payments from a specific account inside of Metamask and seprating funds that way as opposed to providing the seed.

@transmute-industries transmute-industries deleted a comment from gjgd Feb 22, 2022
@gjgd gjgd merged commit 7900563 into main Feb 22, 2022
@gjgd gjgd deleted the add-support-for-eth-private-key branch February 22, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for providing a private key instead of mnemonic to run an element node
3 participants