Update Docs and DID Revocation Tests #223
Conversation
…ransmute into feat/did-gpg-ocap
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 88.42% 88.05% -0.38%
==========================================
Files 39 39
Lines 743 770 +27
Branches 64 66 +2
==========================================
+ Hits 657 678 +21
- Misses 84 89 +5
- Partials 2 3 +1
Continue to review full report at Codecov.
|
docs/did/revocation.md
Outdated
|
|
||
| ## Revocation of a DID Key | ||
|
|
||
| [W3C DID Key Revocation Reference](https://w3c-ccg.github.io/did-spec/ #key-revocation-and-recovery) |
There was a problem hiding this comment.
You have a space here that breaks your hyperlink
|
|
||
| ## Revocation of a DID Key | ||
|
|
||
| [W3C DID Key Revocation Reference](https://w3c-ccg.github.io/did-spec/ #key-revocation-and-recovery) |
| @@ -0,0 +1,42 @@ | |||
| ## Revocation of a DID | |||
There was a problem hiding this comment.
Can we use hyperlinks or symlinks instead of duplicating documentation?
There was a problem hiding this comment.
no, because github will only serve documentation from that folder. its basically like a dist folder that gets checked into source.
There was a problem hiding this comment.
I wish it were possible to not have it be this way.
There was a problem hiding this comment.
actually, we can just eliminate the docs folder in the did package.
| } | ||
| ``` | ||
|
|
||
| A revocationCert is a DID Document, with a signed json object property. The cert should never be handled by itself. This is why the full document is returned by the create revocationCert call. |
There was a problem hiding this comment.
It says revocationCert is a DID Document, but in the example above, it is not
No description provided.