Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding diff dataset command #109

Merged
merged 9 commits into from
Oct 25, 2021

Conversation

avdata99
Copy link
Contributor

@avdata99 avdata99 commented Oct 7, 2021

In progress
Related to #101

This PR creates the dpckan dataset diff and the dpckan resource diff command
This PR could be merged and these new functions could be useful.
They are not finished and they are in a very basic state.

Nice thing to add:

  • Use hash functions to compare file resources
  • Run a diff for each resource while diffing datasets
  • Use this function to avoid updating a resource when is not necessary.
  • Some fields require different comparison functions (e.g. resource formats are string and the case is not important). Maybe to define some case_insensitive_string_comp, tags_comp, org_comp or function like this could be re-usable and the code will be cleaner

@avdata99 avdata99 changed the title WIP: Adding diff dataset command Adding diff dataset command Oct 7, 2021
@gabrielbdornas gabrielbdornas merged commit eb3bcb0 into transparencia-mg:dev Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants