Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests and CI for 2023-W50 #8

Merged
merged 12 commits into from
Dec 10, 2023
Merged

Update tests and CI for 2023-W50 #8

merged 12 commits into from
Dec 10, 2023

Conversation

khaeru
Copy link
Contributor

@khaeru khaeru commented Dec 10, 2023 •
edited

  • Always instantiate sdmx…PrimaryMeasureRelationship and similar classes. Using an instance, rather than the type, is necessary for sdmx.to_xml() to dispatch correctly.
  • Satisfy mypy 1.7.0 throughout the code base.
  • Expand and improve CI:
    • Matrix CI for Python 3.8–3.12 and Linux, Windows, and macOS.
    • Use pre-commit to invoke mypy and ruff for code quality checking; drop separate "lint" workflow.

@khaeru khaeru added the bug Something isn't working label Dec 10, 2023
@khaeru khaeru self-assigned this Dec 10, 2023
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@khaeru khaeru force-pushed the ci-2023-W50 branch 4 times, most recently from 9b9b8f8 to 33140a9 Compare December 10, 2023 22:01
@khaeru
Satisfy mypy
4f64be9
@khaeru
Replace flake8 config with equivalent ruff config
7f6b8cc
@khaeru
Add pre-commit configuration
5e8c1ca
@khaeru
Update CI workflows
2fa0c46 
- Replace "lint" workflow with "pre-commit" job in "pytest" workflow.
- Remove TESTPYPI_TOKEN from "publish" workflow.
- Matrix "pytest" job for all OS and supported Python versions.
@khaeru
Make type annotations Python 3.8 compatible
4cac7a9
@khaeru khaeru merged commit 191eab7 into main Dec 10, 2023
18 checks passed
@khaeru khaeru deleted the ci-2023-W50 branch December 10, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@khaeru khaeru

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khaeru @codecov-commenter