Docs: clarify parallel-direct-writes and cache.files #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trapexit
reviewed
Aug 26, 2023
trapexit
reviewed
Aug 26, 2023
Clarify that paralell direct can only be enabled where the kernel version supports it, which is 6.2+. State the two cache.files modes which can support parallel direct writes in the description.
This makes it clear, along with the previous commit, that per-process will allow us to use parallel direct writes as they will mount with the equivalent of cache.files=off (i.e. direct_io)
Change which 'comm' name -> whose 'comm' name. Whose implies possession, and the process possess the name we're matching
DavidFair
force-pushed
the
readme_direct_parallel
branch
from
9d03fac
to
b545352
Compare
|
Brill, I was tempted to drop direct_io mentions in the section initially but didn't want to go ahead without that feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies some points around cache.files and parallel-direct-writes. See commit messages for details:
Tl;dr:
parallel-direct-writes- Steer people to usecache.files=offinstead ofdirect_io- Clarify which eachcache.filesimplies, so people with existing mount options can (hopefully) say, I can consolidate my mount flags intocache.files=foocache.files=offis the process name does not match