Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging spconv into SparseConvNet #7

Closed
Benzlxs opened this issue Jan 22, 2019 · 1 comment
Closed

Merging spconv into SparseConvNet #7

Benzlxs opened this issue Jan 22, 2019 · 1 comment

Comments

@Benzlxs
Copy link
Contributor

Benzlxs commented Jan 22, 2019

Hey Yan yan,
Thank you for the amazing work.
Considering that SparseConvNet has more interface functions, such as average pooling and concatTable ect., and that only differences between spconv and SparseConvNet are gpu indice generation and gather-gemm-scatter algorithm, are you planning to add gpu indice generation and gather-gemm-scatter into SparseConvNet released by Facebook or just to develop more functions based on spconv?
@traveller59
Copy link
Owner

I have no plan to merge to SparseConvNet. My python and c++ code both are completely different with SparseConvNet.
The avg pool seems not used in modern convolution models. The ConcatTable is just a python module. Many layers in SparseConvNet can be implemented in pure-pytorch.

@Benzlxs Benzlxs closed this as completed Jan 27, 2019
@markweberdev markweberdev mentioned this issue Jun 7, 2023
Open
@hlyyyyy hlyyyyy mentioned this issue Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Benzlxs @traveller59