Enable CPU-only builds on macOS #616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables CPU-only builds on macOS. It in addition to the changes to
spconv, this also requires some changes toccimportandcumm. They are implemented at https://github.com/tilmantroester/ccimport/tree/macos_support andhttps://github.com/tilmantroester/cumm/tree/macos_cpu_only. Let me know if you want PRs for those as well.
I've tested this on an arm64 mac, with both Apple and conda clang.
For development installs (
pip install -e), both JIT and non-JIT work. Standard installs require the non-JIT build.Compiling with OpenMP works but the results are unstable, so I disabled OpenMP on macOS.
tests/test_conv.pypasses for the cases where CPU implementations are available (i.e.ConvAlgo.Nativebut not for exampleSparseGlobalMaxPool).