Write the first action version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuband
reviewed
Jun 8, 2020
giuband
reviewed
Jun 8, 2020
giuband
reviewed
Jun 8, 2020
javiertejero
reviewed
Jun 9, 2020
src/entrypoint.tsx
Outdated
| client | ||
| ) | ||
| if (reviewCount < requiredReviews) { | ||
| toolkit.exit.failure( |
There was a problem hiding this comment.
I guess this raises an exception that is not catched and break execution flow, otherwise we need an else
javiertejero
reviewed
Jun 9, 2020
src/entrypoint.tsx
Outdated
| } | ||
|
|
||
| Toolkit.run(async (toolkit: Toolkit) => { | ||
| toolkit.log.info('Running Action') |
There was a problem hiding this comment.
I would refactor out this run method to the lib so we can test it mocking the toolkit
javiertejero
approved these changes
Jun 9, 2020
giuband
approved these changes
Jun 9, 2020
giuband
reviewed
Jun 9, 2020
namelivia
force-pushed
the
inital_development
branch
from
d59cc63
to
248ca88
Compare
namelivia
force-pushed
the
inital_development
branch
from
798ae70
to
c5b455a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first version of our first custom Github action.
The purpose of this action is to scan for certain labels on the PR, then check for a configuration file that will be present on the repo with pairs like
migration, 4,typescript, 5etc... and then if there is a match it will check if the PR has been approved by at least the highest matching number of reviewers.Why is this based on labels? So this can be plugged-in with other open-source github actions we already have like the one that auto-labels the PR's based on the files that are being commited. By pluggin-in these two we can create things like "if a PR contains a migration file, tag the file as
migrationand do no let it be merged until approved by 2 people"Ideally we could opensource this action too so other people can use it in their workflows. I'm syncing with @javiertejero tomorrow morning about this.
But first I'm creating this mainly for @giuband , there is some stuff I'll like to be reviewed, specially the javascript/typescript flavor, I just adopted some configurations from somewhere else and these are not our standards, so I would be completely ok if we decide to setup different customization.