Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix URR processing and change reporting #210

Merged
merged 2 commits into from Sep 28, 2020
Merged

fix URR processing and change reporting #210

merged 2 commits into from Sep 28, 2020

Conversation

RoadRunnr
Copy link
Member

  • fix generation of GTP Change Report IEs
  • band-aid fix for not querying URRs when there is event to report

mgumz
mgumz reviewed Sep 10, 2020
View reviewed changes
Copy link
Contributor

@mgumz mgumz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the subject of the commit "don't trigger URR queries when we have on events to report" … is the "on" a typo and actually meant "when we have no events to report"?

@RoadRunnr
Copy link
Member Author

the subject of the commit "don't trigger URR queries when we have on events to report" … is the "on" a typo and actually meant "when we have no events to report"?

fixed

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 78.662% when pulling 5cf42a38d37707f5116e59ffdc90eb089443e376 on fix/change_reporting into 8b89e9d on master.

@RoadRunnr RoadRunnr merged commit a37db0a into master Sep 28, 2020
@RoadRunnr RoadRunnr deleted the fix/change_reporting branch September 28, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgumz mgumz mgumz left review comments

@fholzhauser fholzhauser fholzhauser approved these changes

@ebengt ebengt Awaiting requested review from ebengt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RoadRunnr @coveralls @fholzhauser @mgumz