Fix warnings of non use variables for Common Tests #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoadRunnr
requested changes
Sep 28, 2020
There was a problem hiding this comment.
I see more warnings, shouldn't they be fixed as well if we touch this?
test/ergw_test_sx_up.erl:166: Warning: variable 'PCtx' is unused
test/ergw_test_sx_up.erl:183: Warning: variable 'PCtx' is unused
test/ergw_test_sx_up.erl:220: Warning: variable 'IP' is unused
test/ergw_test_sx_up.erl:220: Warning: variable 'InPortNo' is unused
test/ergw_test_sx_up.erl:220: Warning: variable 'Packet' is unused
test/ergw_test_sx_up.erl:282: Warning: function sx_reply/2 is unused
test/ergw_pgw_test_lib.erl:715: Warning: variable 'RemoteCntlTEI' is unused
test/ergw_ggsn_test_lib.erl:379: Warning: variable 'RemoteCntlTEI' is unused
test/ggsn_SUITE.erl:826: Warning: variable 'Req' is unused
test/ggsn_SUITE.erl:838: Warning: variable 'Req' is unused
Sure, will be done. I have not seen this warnings before. Thanks. |
vkatsuba
force-pushed
the
fix/remove_warnings_of_unused_variables_for_ct
branch
from
d6533df
to
55563f1
Compare
RoadRunnr
approved these changes
Sep 28, 2020
RoadRunnr
deleted the
fix/remove_warnings_of_unused_variables_for_ct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.