Improve memory consumption #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For every established GTP-U connection, several metric probes are created upon connection (see src/gtp_u_edp_port.erl). Among the created probes are 2 of type "histogram". An histogram is represented as a process in the GTP-U-Node which will be initialized with a `min_heap_size` of 40k WORDS (8byte on 64bit machines). See [1] and [2] for a discussion about the issue. Neither of the preconditions for increasing the `min_heap_size` are met: * the histograms are kept over a long period of time (and are not short lived) * the amount of processes keep growing with the amount of established connections This commit sets the `min_heap_size` option of the spawned processes responsible for the histogram to the default Erlang value and thus, decreases the memory consumption of the histograms and allow the GC to work. [1]: Feuerlabs/exometer_core#100 [2]: http://erlang.org/doc/efficiency_guide/processes.html
1 similar comment
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For every established GTP-U connection, several metric probes are
created upon connection (see src/gtp_u_edp_port.erl). Among the created
probes are 2 of type "histogram". An histogram is represented as a
process in the GTP-U-Node which will be initialized with a
min_heap_sizeof 40k WORDS (8byte on 64bit machines).See 1 and 2 for a discussion about the issue.
Neither of the preconditions for increasing the
min_heap_sizeare met:lived)
connections
This commit sets the
min_heap_sizeoption of the spawned processesresponsible for the histogram to the default Erlang value and thus,
decreases the memory consumption of the histograms and allow the GC to
work.