Fix stopping PFCP timers #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoadRunnr
reviewed
Feb 18, 2021
upf/upf_pfcp_server.c
Outdated
| @@ -491,7 +491,7 @@ restart_response_timer (pfcp_msg_t * msg) | |||
| upf_debug ("Msg Seq No: %u, idx %u\n", msg->seq_no, id); | |||
|
|
|||
| if (msg->timer != ~0) | |||
ivan4th
force-pushed
the
fix/stopping-pfcp-timers-1
branch
from
24430ba
to
572ac43
Compare
5 tasks
ivan4th
force-pushed
the
fix/stopping-pfcp-timers-1
branch
from
572ac43
to
2f34f1f
Compare
ivan4th
force-pushed
the
fix/stopping-pfcp-timers-1
branch
from
2f34f1f
to
1ae05e5
Compare
There was a corner case of timers "firing" after being stopped because their "user handles" being already collected into the 'expires' vector in pfcp_process(). This caused msg_pool corruption.
ivan4th
force-pushed
the
fix/stopping-pfcp-timers-1
branch
from
1ae05e5
to
5e4a3e8
Compare
sergeymatov
approved these changes
Feb 22, 2021
sergeymatov
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "resurrection" of #7.
After we've reverted #7 and replaced it with #12, we first had the problem resurface in #44, which we mitigated to a degree by #49, but then we were hit by #80.
Fixes #80.