extracted a minifier class

php/framework/src/travi/framework/dependencyManagement/JavascriptList.php

@@ -2,62 +2,34 @@
 
 namespace travi\framework\dependencyManagement;
 
-use travi\framework\utilities\Environment;
-
 class JavascriptList implements DependencyList
 {
-    /** @var  Environment */
-    private $environment;
+    /** @var  Minifier */
+    private $minifier;
 
     private $list = array();
 
     /**
      * @param $dependency
      * @return void
      */
-    function add($dependency)
+    public function add($dependency)
     {
         array_push($this->list, $dependency);
     }
 
     /**
      * @return string[]
      */
-    function get()
-    {
-        $this->minifyList();
-
-        return $this->list;
-    }
-
-    /**
-     * @param $environment Environment
-     */
-    public function setEnvironment($environment)
+    public function get()
     {
-        $this->environment = $environment;
-    }
+        $list = $this->minifier->minifyList($this->list);
 
-    private function minifyList()
-    {
-        if (!$this->environment->isLocal()) {
-            foreach ($this->list as &$dependency) {
-                $dependency = $this->minify($dependency);
-            }
-        }
+        return $list;
     }
 
-    /**
-     * @param $dependency
-     * @return mixed
-     */
-    private function minify($dependency)
+    public function setMinifier($minifier)
     {
-        return preg_replace(
-            '/\/(resources.*)\/(css|js)\//',
-            '/$1' . DependencyManager::MIN_DIR . '/$2/',
-            $dependency,
-            1
-        );
+        $this->minifier = $minifier;
     }
 }

php/framework/src/travi/framework/dependencyManagement/Minifier.php

@@ -0,0 +1,44 @@
+<?php
+
+namespace travi\framework\dependencyManagement;
+
+use travi\framework\utilities\Environment;
+
+class Minifier
+{
+    /** @var  Environment */
+    private $environment;
+
+    public function minifyList($list)
+    {
+        if (!$this->environment->isLocal()) {
+            foreach ($list as &$dependency) {
+                $dependency = $this->minify($dependency);
+            }
+        }
+
+        return $list;
+    }
+
+    /**
+     * @param $dependency
+     * @return mixed
+     */
+    private function minify($dependency)
+    {
+        return preg_replace(
+            '/\/(resources.*)\/(css|js)\//',
+            '/$1' . DependencyManager::MIN_DIR . '/$2/',
+            $dependency,
+            1
+        );
+    }
+
+    /**
+     * @param $environment Environment
+     */
+    public function setEnvironment($environment)
+    {
+        $this->environment = $environment;
+    }
+}

php/framework/test/php/dependencyManagement/JavascriptListTest.php

@@ -5,6 +5,7 @@
 use PHPUnit_Framework_TestCase;
 use travi\framework\dependencyManagement\DependencyManager;
 use travi\framework\dependencyManagement\JavascriptList;
+use travi\framework\dependencyManagement\Minifier;
 use travi\framework\utilities\Environment;
 
 class JavascriptListTest extends PHPUnit_Framework_TestCase
@@ -15,10 +16,12 @@ class JavascriptListTest extends PHPUnit_Framework_TestCase
 
     public function setUp()
     {
-        $this->environment = $this->getMock('Environment');
+        $this->environment = $this->getMock('travi\\framework\\utilities\\Environment');
+        $minifier = new Minifier();
+        $minifier->setEnvironment($this->environment);
 
         $this->list = new JavascriptList();
-        $this->list->setEnvironment($this->environment);
+        $this->list->setMinifier($minifier);
     }
 
     public function testThatListIsEmptyIfNothingHasBeenAdded()
@@ -37,6 +40,10 @@ public function testThatJavascriptFileCanBeAddedToTheList()
 
     public function testThatFullSourceIsReturnedWhenLocal()
     {
+        $this->environment->expects($this->once())
+            ->method('isLocal')
+            ->will($this->returnValue(true));
+
         $someScript = '/resources/js/some script';
 
         $this->list->add($someScript);
@@ -46,6 +53,10 @@ public function testThatFullSourceIsReturnedWhenLocal()
 
     public function testThatListIsMinifiedWhenNotLocal()
     {
+        $this->environment->expects($this->once())
+            ->method('isLocal')
+            ->will($this->returnValue(false));
+
         $this->list->add('/resources/js/some script');
 
         $this->assertEquals(