ensures that the validation list is never null to fix #75

travi · Nov 27, 2014 · ebd914f · ebd914f
1 parent b65607d
commit ebd914f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/php/framework/src/travi/framework/dependencyManagement/DependencyManager.php b/php/framework/src/travi/framework/dependencyManagement/DependencyManager.php
@@ -90,6 +90,7 @@ public function addValidations($list, $form)
 
     public function getDependencies()
     {
+        $this->lazyInitializeList('validations');
         $this->sortStyleSheets();
 
         return $this->requirementLists;

diff --git a/php/framework/test/php/dependencyManagement/DependencyManagerTest.php b/php/framework/test/php/dependencyManagement/DependencyManagerTest.php
@@ -660,11 +660,12 @@ public function testEmptyStringNotAddedWhenReturnedAsDependency()
 
     public function testThatEmptyListsReturnedIfNoDependenciesToList()
     {
-        $dependencies = $this->dependencyManager->getDependencies();
+        $dependencies = $this->dependencyManager->getDependenciesInProperForm();
 
         $this->assertEmpty(array(), $dependencies['css']);
         $this->assertEquals(array(), $dependencies['js']);
         $this->assertEquals(array(), $dependencies['clientTemplates']);
+        $this->assertEquals(array(), $dependencies['validations']);
     }
 
     public function testThatCriticalJsListIncludesModernizr()