Skip to content

Commit

Permalink
Remove use_cloud_build option
Browse files Browse the repository at this point in the history
`use_cloud_build` option has already been deprecated in gcloud v112.0.0
and removed in gcloud v114.0.0
  • Loading branch information
shunyi authored and shunyi committed Jun 16, 2016
1 parent 15c5ff7 commit 4ce46ff
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions lib/dpl/provider/gae.rb
Expand Up @@ -58,10 +58,6 @@ def no_promote
options[:no_promote]
end

def use_cloud_build
options[:use_cloud_build] || 'false'
end

def verbosity
options[:verbosity] || 'warning'
end
Expand All @@ -75,7 +71,6 @@ def no_stop_previous_version
end

def push_app
context.shell "#{GCLOUD} config set app/use_cloud_build #{use_cloud_build}"
command = GCLOUD
command << ' --quiet'
command << " --verbosity \"#{verbosity}\""
Expand Down
1 change: 0 additions & 1 deletion spec/provider/gae_spec.rb
Expand Up @@ -8,7 +8,6 @@

describe '#push_app' do
example 'with defaults' do
allow(provider.context).to receive(:shell).with("#{DPL::Provider::GAE::GCLOUD} config set app/use_cloud_build false").and_return(true)
allow(provider.context).to receive(:shell).with("#{DPL::Provider::GAE::GCLOUD} --quiet --verbosity \"warning\" --project \"test\" preview app deploy \"app.yaml\" --version \"\" --docker-build \"remote\" --promote").and_return(true)
provider.push_app
end
Expand Down

0 comments on commit 4ce46ff

Please sign in to comment.