S3 upload should not set an empty content-type

[stof]

When the mime type is not known by the mime-types gem, it would be better to set a application/octet-stream mime type than an empty string.

[BanzaiMan]

Thanks for opening the issue. What are effects of not setting the Content-Type header?

[stof]

if you don't set it when uploading, I think S3 automatically sets it to application/octet-stream (which means that browsers will download the file, while an empty content-type gets treated like a text content at least in Firefox and so displayed on screen even when it is not textual)

[BanzaiMan]

Please test it with:

deploy:
  provider: s3
  edge:
    branch: 's3-content-type'
  ⋮ # rest

[stof]

Actually, it does not set it to application/octet-stream (this may be a feature of s3cmd for unknown types).

But omitting the content-type makes the file be downloaded by Firefox instead of being displayed as text as previously (which was very confusing when the file was not a text file). So I would vote +1 on your fix.

[stale]

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

[BanzaiMan]

@stof @sylveon @peternewman You all have expressed interest in resolving this issue. Could you test the PR one last time, so that we can merge and release the fix?

Thanks.

[peternewman]

Not guilty sorry @BanzaiMan aside from pointing out it's a duplicate to try and keep the issue list clean.

[BanzaiMan]

@peternewman Sorry for the noise!

[stale]

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues