add s3 --host_prefix

[svenfuchs]

refers to #1079

can be tested with

deploy:
  provider: s3
  force_path_style: true
  edge:
    branch: sf-s3-subdomain

[mfrancis95]

From dpl would it be tested using --no-host_prefix?

[svenfuchs]

@mfrancis95 yes, but if you put host_prefix: false into your .travis.yml file then our build script compiler will pass --no-host_prefix to dpl

[mfrancis95]

Just tested it. It looks like it's still trying to deploy to [bucket].[endpoint]:443

[svenfuchs]

@mfrancis95 i now think that the option we want might be force_path_style https://docs.aws.amazon.com/sdkforruby/api/Aws/S3/Client.html

i have tested this with a local ruby script, and it has output the expected endpoint, keeping the bucket name on the path:

opening connection to s3.amazonaws.com:443...
opened
starting SSL for s3.amazonaws.com:443...
SSL established, protocol: TLSv1.2, cipher: ECDHE-RSA-AES128-GCM-SHA256
<- "PUT /travis-dpl-test/dpl_test HTTP/1.1\r\nContent-Type: ...
...

in order to keep this consistent with S3's terminology i have renamed the option on our side, too. so you now want to pass:

deploy:
  provider: s3
  force_path_style: true
  edge:
    branch: sf-s3-subdomain

wanna give this a try?

[mfrancis95]

@svenfuchs that worked! Thank you. This should make the Travis S3 deployment a lot more compatible with S3 gateways out there.

[mfrancis95]

Thanks @svenfuchs. Approximately how long will it take for this change to go live on travis-ci.com?

[svenfuchs]

@mfrancis95 we'll release the gem as a preview release today or tomorrow, but that will mean you still need to opt in via edge: true (no need to specify a branch then)

there's no timeline on releasing a stable version ... we'll first want to see what kind of issues come up.

[mfrancis95]

@svenfuchs I opted in after seeing this post: https://blog.travis-ci.com/2019-08-27-deployment-tooling-dpl-v2-preview-release

But I got this issue:

/home/travis/.rvm/gems/ruby-2.4.5/gems/cl-1.1.1/lib/cl/parser.rb:21:in `initialize': invalid option: --edge (OptionParser::InvalidOption)

[svenfuchs]

woha. thanks for the report @mfrancis95

i've just pushed a change that should fix this.

[mfrancis95]

Thanks @svenfuchs. It works!