pages: Fix deploy keys #1243
Merged
pages: Fix deploy keys #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a hardcoded github.com in the pages provider's deploy key validation check, which breaks deployment pipelines running against GitHub Enterprise. Signed-off-by: afzhou <afzhou@ibm.com>
This fixes usage of read-write deploy keys with the pages deploy_key option when the Travis default private key is only authorized for read-only access. Signed-off-by: afzhou <afzhou@ibm.com>
0az
force-pushed
the
fix-pages-deploy_key-ghe
branch
from
2f2e050
to
6b1eef1
Compare
This makes debugging broken deployments slightly easier, as error messages are no longer suppressed. - Enable echo for push and disable /dev/null redirection - Print SSH key fingerprint and randomart Signed-off-by: afzhou <afzhou@ibm.com>
0az
force-pushed
the
fix-pages-deploy_key-ghe
branch
from
6b1eef1
to
4138471
Compare
GbArc
approved these changes
May 6, 2022
radekl
reviewed
Jun 10, 2022
| @@ -155,7 +155,8 @@ def git_commit | |||
| end | |||
|
|
|||
| def git_push | |||
| shell :git_push, echo: false | |||
| shell 'ssh-keygen -lv -f /home/travis/.dpl/deploy_key' | |||
There was a problem hiding this comment.
This line has broke our pipelines. We are using token authentication and the file which is checked here is not available and build breaks due to that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pages: Fix deploy key check on GHE
Remove a hardcoded github.com in the pages provider's deploy key validation check, which breaks deployment pipelines running against GitHub Enterprise.
Force usage of selected identity when using SSH for git
This fixes usage of read-write deploy keys with the pages deploy_key option when the Travis default private key is only authorized for read-only access.
pages: Show more information when pushing
This makes debugging broken deployments slightly easier, as error messages are no longer suppressed.
Signed-off-by: afzhou afzhou@ibm.com