Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide quiet option to S3 provider #877

Merged
merged 1 commit into from Oct 4, 2018
Merged

Provide quiet option to S3 provider #877

merged 1 commit into from Oct 4, 2018

Conversation

BanzaiMan
Copy link
Contributor

Users may end up uploading thousands of files, which will eat up log
capacity.

Users may end up uploading thousands of files, which will eat up log 
capacity.
@BanzaiMan
Copy link
Contributor Author

This could be a useful option for other potentially noisy providers, but we'll start from here.

Copy link
Contributor

@cotsog cotsog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks!

@soulim
Copy link

soulim commented Oct 4, 2018

@BanzaiMan thanks a lot for adding this option. Have you considered a common option for all providers and not just S3? Then it would allow consistent behaviour for all providers.

If I'm not mistaken it should be enough to add conditional logging in this line:

$stderr.puts(message)

Something like this:

def log(message)
  $stderr.puts(message) unless options[:quiet]
end

@BanzaiMan
Copy link
Contributor Author

BanzaiMan commented Oct 4, 2018

@soulim I have not considered it. It could work, but I am afraid that doing so without examining each deployment provider's behavior could make diagnosis hard when problems arise.

@BanzaiMan
Copy link
Contributor Author

Maybe we should choose a different name for this option. Say, display_uploaded_files: false, with the default being true.

@BanzaiMan
Copy link
Contributor Author

I didn't mean to do that.

@BanzaiMan
Copy link
Contributor Author

See #882 for further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants