Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --only option to firebase deploy #959

Closed
wants to merge 2 commits into from

Conversation

quibusus
Copy link

Firebase allows deploying multiple sites to one firebase project. This option is missing in Travis

https://firebase.google.com/docs/hosting/multisites

firebase deploy --only hosting:target-name

@BanzaiMan
Copy link
Contributor

Hello, there.

Is there a test deployment for this PR?

@quibusus
Copy link
Author

Hello, there.

Is there a test deployment for this PR?

Nope, the PR is all there is

@BanzaiMan
Copy link
Contributor

Please test it.

@inquisitive-ginger
Copy link

Any progress on this? Definitely would be used in a few projects I'm on.

@latifs
Copy link

latifs commented Mar 29, 2019

@quibusus, This is a great PR, I really need that, can you update your branch?

@inquisitive-ginger
Copy link

@quibusus @BanzaiMan ... Happy to take this on, what needs to happen to get this moving again?

@BanzaiMan
Copy link
Contributor

Please test it. https://github.com/travis-ci/dpl/blob/master/.github/CONTRIBUTING.md#testing-dpl-in-the-context-of-travis-ci-builds

@quibusus
Copy link
Author

quibusus commented Apr 5, 2019

@BanzaiMan thanks for the details 👍
@zpritchett please, if you have time, please take over 👍

@svenfuchs
Copy link
Contributor

@quibusus @zpritchett the option --only has been added in master https://github.com/travis-ci/dpl/blob/master/lib/dpl/providers/firebase.rb#L19

The current master has the next major version v2 which we are about to release. You can opt into using this version by adding:

deploy:
  provider: firebase
  edge:
    branch: master
⋮

I am going to close this one here. Please feel free to re-open it.

@svenfuchs svenfuchs closed this Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants