Improved windows host support (git bash & cygwin) #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using windows as a host OS, GOROOT must be a Windows path. This condition applies whenever invoking go, either as part of the installation or when written into the .env file. Also, the .exe files in the Windows Go distribution do not have an executable flag set. This change addresses both of these issues, allowing at least binary installs to run correctly when running under git bash or cygwin.
|
I've updated this to add support for pkg/tool exe's. Any feedback on the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using windows as a host OS,
GOROOTmust be a Windows path. This condition applies whenever invoking go, either as part of the installation or when written into the .env file. Also, the .exe files in the Windows Go distribution do not have an executable flag set.This PR addresses both of these issues, allowing binary installs to run correctly when running under git bash or cygwin.