Add some initial Honeycomb support #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sends some initial data about the incoming requests to Honeycomb.
sarahhodne
force-pushed
the
hh/honeycomb
branch
from
cf8e55b
to
d90b1c9
Compare
Since we create the builder in a init() and set the write key after all the configuration is parsed, the builder ends up without a write key and no events are sent.
started - now makes for negative durations
added 14 commits
January 30, 2017 16:07
This way we can calculate success/failure percentage by calculating AVG(success).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some Honeycomb integration. It sends the following events:
All events contain the
X-Request-IDvalue if the HTTP header is set (we don't set this anywhere yet, but that way it's tracked when we start to do that).The HTTP request event has information about the request duration, the HTTP method, URL path (e.g.
/instances/fafafafa-fafa-fafa-fafa-fafafafafafa), response code (e.g.200), and the number of bytes written.The clone event differs a bit in information depending on how far in the clone it gets. It always has the image name, total duration, whether the clone succeeded or failed (and the error if it failed), and a string field that specifies how far the clone got (roughly "where did the
Start()method return).In addition, it tracks this information as it becomes available:
Startmethod before the clone is started, which is spent doing things like "find the base VM and snapshot" and "find the resource pool to place the VM in")The terminate event is similar in that it tracks more information as it goes along. It also tracks total duration, whether it succeeded or failed, the error, and how far in the method it got before returning. In addition it tracks: