Update spec/support/matchers.rb #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubinius does not yet destructure block (or method) arguments in 1.9 mode. This change makes the specs pass on Rubinius. It's not clear to me why destructering is being used here. Ruby will already destructure a single Array-ish argument into separate block argument locals. In this case, unless you want, give `a, b` passed, `name, content = a` and NOT `name, content = a, b`, the unparenthesized (ie non-extra-level-destructuring) should work fine. If that makes any sense. :)
|
For reference rubinius/rubinius#1953 |
svenfuchs
added a commit
that referenced
this pull request
Oct 11, 2012
Update spec/support/matchers.rb
|
@brixen thank you! :) |
everything14
pushed a commit
that referenced
this pull request
Mar 24, 2023
Fixed the spec and VCR format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubinius does not yet destructure block (or method) arguments correctly in all cases in 1.9 mode. This change makes the specs pass on Rubinius.
It's not clear to me why the extra destructering is being used here. The #files method is returning an Array of two-element Arrays. Ruby will already destructure that Array into
name, content.I'm working on a smaller repro and I'll file an issue on Rubinius tracker when I get that.