New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build lifecycle docs #333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided on an ordered list, since it is certainly an ordered operation. Also am now using nested unordered lists to give additional details. Modified some css to make it look nice.
❤️ Thank you! |
I like it! Would it look OK without those list CSS overrides? |
This looks good to me, @roidrage your thoughts? |
@nschonni Not really. I'll comment on the diff... |
margin: 1em 0; | ||
} | ||
#main ol li ul li { | ||
list-style-type: circle; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Anyone have any more thoughts on this? I would love for it to be merged. 😄 |
@troyswanson thanks so much for the updated docs! |
Any time! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the documentation to reflect the current lifecycle for builds. Also tries to offer examples for what types of commands to run during the various hooks. This is my best guess based on my interpretation of the code, but I'm open to being wrong about any of this. Here's the new copy:
cd
to clone directorybefore_install
commandssudo apt-get update
install
commandsbefore_script
commandsscript
commandsafter_success
orafter_failure
commandsafter_script
commandsAnd here's a screenshot of what it looks like:
Feel free to let me know what you think!
Ref #239