New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phantom 1.8 crashes when appending and removing an iframe #1074

Closed

shane-tomlinson opened this issue Apr 27, 2013 · 1 comment

Labels

feature-request

shane-tomlinson commented Apr 27, 2013

We started to see this issue (ariya/phantomjs#10947) manifest as soon as we added a test which dynamically adds and removes iframes.

Travis uses PhantomJS version 1.8.1, this issue has been resolved for 1.9 release.

If I remove the iframe, the crash does not occur.

The relevant code snippets:

Code that appends iframe: https://github.com/mozilla/browserid/blob/b2g_dev_tos_pp/resources/static/dialog/js/modules/inline_tospp.js#L60-L63
Iframe template: https://github.com/mozilla/browserid/blob/b2g_dev_tos_pp/resources/static/dialog/views/inline_tospp.ejs
Test that exercises the code and triggers that crash: https://github.com/mozilla/browserid/blob/b2g_dev_tos_pp/resources/static/test/cases/dialog/js/modules/inline_tospp.js#L34-L49

roidrage mentioned this issue

Bump PhantomJS to 1.9.0 travis-ci/travis-cookbooks#173

Merged

Contributor

sarahhodne commented Feb 13, 2014

I believe this has been fixed, since we upgraded PhantomJS. Closing this for now, please let me know if you are still seeing this.

sarahhodne closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment