Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs are not tested anymore when using the branch whilelist #5172

Closed
stof opened this issue Nov 26, 2015 · 4 comments
Closed

PRs are not tested anymore when using the branch whilelist #5172

stof opened this issue Nov 26, 2015 · 4 comments

Comments

@stof
Copy link

stof commented Nov 26, 2015

Previously, when using the branch whitelist, PRs targetting one of the whitelisted branch were triggering a build (but the push build was skipped).
It looks like both builds are now skipped. This makes the whitelist much less useful (as PRs sent from a feature branch in the repo to the master branch are not tested anymore).

See FriendsOfSymfony/FOSRestBundle#1231

@stof
Copy link
Author

stof commented Nov 26, 2015

Note that things are working fine on .com currently

@BanzaiMan
Copy link
Contributor

Take a look at https://travis-ci.org/FriendsOfSymfony/FOSRestBundle/requests. It shows that commit FriendsOfSymfony/FOSRestBundle@cf69701 triggered a build but FriendsOfSymfony/FOSRestBundle@8cb50ec did not. This probably means that the latter contains some YAML syntax error, and we were not able to configure a build.

@stof
Copy link
Author

stof commented Nov 27, 2015

Indeed, there is a syntax error. It would be great to report some feedback in such case (you could mark the commit status as errored, with a message saying the config file is invalid). Otherwise, it is hard to understand what happens.

@BanzaiMan
Copy link
Contributor

Right. That's basically what #2025 addresses. I'm closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants