Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias [ci skip] to [skip ci] #911

Closed
sethvargo opened this issue Feb 5, 2013 · 12 comments
Closed

alias [ci skip] to [skip ci] #911

sethvargo opened this issue Feb 5, 2013 · 12 comments

Comments

@sethvargo
Copy link
Contributor

I don't know how many times I accidentally kick off a build because I add [skip ci] instead of [ci skip] to my commit message.

It'd be nice if Travis honored both, and I think it would save you guys some builds 😄

@rubiii
Copy link
Contributor

rubiii commented Feb 5, 2013

awesome proposal ✨ i always have to think twice before writing [ci skip] because to me it feels backwards.

@sarahhodne
Copy link
Contributor

The thought behind it is that you can send commands to the CI server. Right now, the only command available is skip. Say we add a feature that lets you pay for a build to be pushed to the front of the queue (this has been discussed and won't be added, I'm just using it as an example). The command might be runquickly or something. You would then do [ci runquickly].

I'm currently undecided on whether adding the alias is a good idea or not, but hopefully the above will help you remember what order they are in now. The change itself for this is relatively simple, a regexp has to be updated in approval.rb.

@sethvargo
Copy link
Contributor Author

I'm thinking more in terms of "English" I want to "skip ci" in my workflow.

@rubiii
Copy link
Contributor

rubiii commented Feb 5, 2013

@henrikhodne i never thought about it as sending commands to ci, but now the naming makes sense.
i would still vote for [skip ci] though.

@rubiii
Copy link
Contributor

rubiii commented Feb 5, 2013

@henrikhodne is the "ci" prefix also supposed to serve as some kind of "travis namespaces inside
commit messages" or is it just about the idea of sending commands?

@tjmcewan
Copy link

👍

@sarahhodne
Copy link
Contributor

Four months later, I can say I'm not really opposed to this change. If anyone wants to send a PR for it, the code is at https://github.com/travis-ci/travis-core/blob/master/lib/travis/requests/services/receive/push.rb#L63 and https://github.com/travis-ci/travis-core/blob/master/lib/travis/model/request/approval.rb#L51.

@tjmcewan
Copy link

@henrikhodne how would feel about a new class that unifies that interface? you'd call it like, say, this: Travis::Command.new(commit['message']).skip?

@roidrage
Copy link
Contributor

Fixed by travis-ci/travis-core#216.

@mathieujobin
Copy link

maybe not the right place to ask this
but can this [ci skip] be placed on a PR message so we can open a PR for review without the double-builds ? I need it per PR, not global, thats why

thanks

@tyru
Copy link

tyru commented Jan 23, 2016

[skip ci] alias doesn't seem to work now?
In this repo, [skip ci] is included in commit message
but Travis CI Build was fired. vim-jp/vital.vim#380

@tyru
Copy link

tyru commented Jan 23, 2016

I'm sorry, I was wrong.
As @mathieujobin said, merge commit was skipped but each message has no [skip ci] string, build was fired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants