-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alias [ci skip] to [skip ci] #911
Comments
awesome proposal ✨ i always have to think twice before writing |
The thought behind it is that you can send commands to the CI server. Right now, the only command available is I'm currently undecided on whether adding the alias is a good idea or not, but hopefully the above will help you remember what order they are in now. The change itself for this is relatively simple, a regexp has to be updated in approval.rb. |
I'm thinking more in terms of "English" I want to "skip ci" in my workflow. |
@henrikhodne i never thought about it as sending commands to ci, but now the naming makes sense. |
@henrikhodne is the "ci" prefix also supposed to serve as some kind of "travis namespaces inside |
👍 |
Four months later, I can say I'm not really opposed to this change. If anyone wants to send a PR for it, the code is at https://github.com/travis-ci/travis-core/blob/master/lib/travis/requests/services/receive/push.rb#L63 and https://github.com/travis-ci/travis-core/blob/master/lib/travis/model/request/approval.rb#L51. |
@henrikhodne how would feel about a new class that unifies that interface? you'd call it like, say, this: |
Fixed by travis-ci/travis-core#216. |
maybe not the right place to ask this thanks |
|
I'm sorry, I was wrong. |
I don't know how many times I accidentally kick off a build because I add
[skip ci]
instead of[ci skip]
to my commit message.It'd be nice if Travis honored both, and I think it would save you guys some builds 😄
The text was updated successfully, but these errors were encountered: